wufe / react-particles-js

Particles.js for React
https://rpj.bembi.dev/
MIT License
1.15k stars 106 forks source link

Remove deprecated lifecycle methods #63

Closed dstroot closed 5 years ago

dstroot commented 5 years ago

Component does not pass react strict mode. Need to remove "componentWillMount" and "componentWillUpdate". Since they don't seem to actually do anything it should be fine.

Cheers!

index.js:1452 Warning: Unsafe lifecycle methods were found within a strict-mode tree:

componentWillMount: Please update the following components to use componentDidMount instead: SideEffect(NullComponent), t

componentWillUpdate: Please update the following components to use componentDidUpdate instead: t

Learn more about this warning here:
https://fb.me/react-strict-mode-warnings
wufe commented 5 years ago

Thanks for your tip. The change will be included in next release (v2.4.0)

dstroot commented 5 years ago

Cool!