wujian16 / Cornell-MOE

A Python library for the state-of-the-art Bayesian optimization algorithms, with the core implemented in C++.
Other
261 stars 64 forks source link

base_prior.py bug? #69

Open shalijiang opened 5 years ago

shalijiang commented 5 years ago

line 120: for the TopHat prior, why is it not log(1/(max - min))? (I guess this one doesn't matter since it's a constant anyway?) line 351, for the NormalPrior, the comment says it returns the log probablity but it seems returning the PDF value, instead of log(pdf).