search

wujy28 / pe

0 stars 0 forks source link

Sequence diagram for Risk Profile Feature in DG does not follow UML conventions #11

Open wujy28 opened 10 months ago

wujy28 commented 10 months ago

Screenshot 2023-11-17 at 5.32.48 PM.png

In the sequence diagram (DG page 45) in the screenshot above, the activation bars of RiskProfileCommandParser , RiskProfileCommand and Model all persist to the same point until the the updated model is returned and responsibility is handed back to the Logic Manager. However, by UML conventions, I believe that your cannot have the return of responsibility or return value for different objects to be all represented in the same back arrow.

nus-se-script commented 10 months ago

Your response not required for this bug as the team has accepted the bug as it is.