search

wukenaihe / google-breakpad

Automatically exported from code.google.com/p/google-breakpad
0 stars 0 forks source link

MinidumpCallback passes a wstring parameter #90

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
MinidumpCallback passes a wstring parameter

This means that it is very tempting for the implementor of MinidumpCallback
to call the .c_str() function, which in many std::wstring implementations
results in a heap allocation (to make space for the null terminator).  I
think the airbag API should pass a |const wchar_t*| instead to help steer
consumers away from making the mistake of using the heap after a crash.

Original issue reported on code.google.com by dar...@gmail.com on 5 Dec 2006 at 1:05

GoogleCodeExporter commented 9 years ago 
Will roll in to patch for #81.

Original comment by mmento...@gmail.com on 5 Dec 2006 at 1:40

GoogleCodeExporter commented 9 years ago 
Checked in with #81, revision [79].

Original comment by mmento...@gmail.com on 7 Dec 2006 at 8:48