search

wukong-m2m / NanoKong

GNU General Public License v2.0
7 stars 3 forks source link

In FBP, double click any component would give you a dialog without background or frame #67

Closed pencilcheck closed 11 years ago

pencilcheck commented 11 years ago

Someone must've changed the css so it is not working anymore, please fix.

senatorjo commented 11 years ago

It's still working. Just the appearance doesn't look good. The only visible changes I can see are the two buttons added after group size. My guess is it's from that change.

On Sun, Dec 23, 2012 at 9:26 PM, Penn Su notifications@github.com wrote:

Someone must've changed the css so it is not working anymore, please fix.

— Reply to this email directly or view it on GitHubhttps://github.com/wukong-m2m/NanoKong/issues/67.

wycc commented 11 years ago

The group_size become spinner. You need to regenerate the fbp.html to use the jquery 1.9.2.

Actually, I don't like the current implementation. The fbp.html is generated by a program. This is easy to have consistency issue. We should generate a javascript only and load it by using $.getScript.

2012/12/24 senatorjo notifications@github.com

It's still working. Just the appearance doesn't look good. The only visible changes I can see are the two buttons added after group size. My guess is it's from that change.

On Sun, Dec 23, 2012 at 9:26 PM, Penn Su notifications@github.com wrote:

Someone must've changed the css so it is not working anymore, please fix.

— Reply to this email directly or view it on GitHub< https://github.com/wukong-m2m/NanoKong/issues/67>.

— Reply to this email directly or view it on GitHubhttps://github.com/wukong-m2m/NanoKong/issues/67#issuecomment-11655024.

YC

Phone: 886-2-23516989 Mobile: 0919816155

senatorjo commented 11 years ago

Just checked make_fbp.py. It is already changed to be using jquery 1.9.2 to generate fbp.html. The new fbp.html is generated everytime master_server.py is run. However, the display problem is still there.

Sen

On Sun, Dec 23, 2012 at 11:38 PM, Yu-Chung Wang notifications@github.comwrote:

The group_size become spinner. You need to regenerate the fbp.html to use the jquery 1.9.2.

Actually, I don't like the current implementation. The fbp.html is generated by a program. This is easy to have consistency issue. We should generate a javascript only and load it by using $.getScript.

2012/12/24 senatorjo notifications@github.com

It's still working. Just the appearance doesn't look good. The only visible changes I can see are the two buttons added after group size. My guess is it's from that change.

On Sun, Dec 23, 2012 at 9:26 PM, Penn Su notifications@github.com wrote:

Someone must've changed the css so it is not working anymore, please fix.

— Reply to this email directly or view it on GitHub< https://github.com/wukong-m2m/NanoKong/issues/67>.

— Reply to this email directly or view it on GitHub< https://github.com/wukong-m2m/NanoKong/issues/67#issuecomment-11655024>.

YC

Phone: 886-2-23516989 Mobile: 0919816155

— Reply to this email directly or view it on GitHubhttps://github.com/wukong-m2m/NanoKong/issues/67#issuecomment-11655695.

senatorjo commented 11 years ago

changed in fbp-multipage repository. Will update it to develop when we merge fbp-multipage with develop. If you cannot wait for it, search for "jquery-ui-1.9.2.custom.js" in make_fbp.py. Replace this string with "jquery-ui-1.9.2.custom.min.js"

pencilcheck commented 11 years ago

Fixed.