wukong-m2m / NanoKong

GNU General Public License v2.0
7 stars 3 forks source link

MOdify the translator to read the multiple page WuXML file #69

Open wycc opened 11 years ago

wycc commented 11 years ago

The tag is added to support the multiple page.

senatorjo commented 11 years ago

All the components are read regardless of their pages now. Let me know if further changes are needed.

wycc commented 11 years ago

Where is your patch? I don't see it yet.

2013/1/6 senatorjo notifications@github.com

All the components are read regardless of their pages now. Let me know if further changes are needed.

— Reply to this email directly or view it on GitHubhttps://github.com/wukong-m2m/NanoKong/issues/69#issuecomment-11925063.

senatorjo commented 11 years ago

There are two commits today: https://github.com/wukong-m2m/NanoKong/commits/fbp-multipage One of them solve the previous problem why fbp-multipage was not working (native port assignment issue).

Sen

On Sat, Jan 5, 2013 at 10:36 PM, Yu-Chung Wang notifications@github.comwrote:

Where is your patch? I don't see it yet.

2013/1/6 senatorjo notifications@github.com

All the components are read regardless of their pages now. Let me know if further changes are needed.

— Reply to this email directly or view it on GitHub< https://github.com/wukong-m2m/NanoKong/issues/69#issuecomment-11925063>.

— Reply to this email directly or view it on GitHubhttps://github.com/wukong-m2m/NanoKong/issues/69#issuecomment-11925114.

wycc commented 11 years ago

However, this issue is related to multi page parser. Is it implemented?

2013/1/6 senatorjo notifications@github.com

There are two commits today: https://github.com/wukong-m2m/NanoKong/commits/fbp-multipage One of them solve the previous problem why fbp-multipage was not working (native port assignment issue).

Sen

On Sat, Jan 5, 2013 at 10:36 PM, Yu-Chung Wang notifications@github.comwrote:

Where is your patch? I don't see it yet.

2013/1/6 senatorjo notifications@github.com

All the components are read regardless of their pages now. Let me know if further changes are needed.

— Reply to this email directly or view it on GitHub< https://github.com/wukong-m2m/NanoKong/issues/69#issuecomment-11925063>.

— Reply to this email directly or view it on GitHub< https://github.com/wukong-m2m/NanoKong/issues/69#issuecomment-11925114>.

— Reply to this email directly or view it on GitHubhttps://github.com/wukong-m2m/NanoKong/issues/69#issuecomment-11925493.

senatorjo commented 11 years ago

My understanding is that parser should be able to read from the application.xml and understand it, right? The current implementation is already doing that , it gets every

tag and parse it regardless of the page. Sen On Sat, Jan 5, 2013 at 11:58 PM, Yu-Chung Wang notifications@github.comwrote: > However, this issue is related to multi page parser. Is it implemented? > > 2013/1/6 senatorjo notifications@github.com > > > There are two commits today: > > https://github.com/wukong-m2m/NanoKong/commits/fbp-multipage > > One of them solve the previous problem why fbp-multipage was not working > > (native port assignment issue). > > > > Sen > > > > On Sat, Jan 5, 2013 at 10:36 PM, Yu-Chung Wang notifications@github.comwrote: > > > > > Where is your patch? I don't see it yet. > > > > > > 2013/1/6 senatorjo notifications@github.com > > > > > > > All the components are read regardless of their pages now. Let me > > > > know > > > > if > > > > further changes are needed. > > > > > > > > — > > > > Reply to this email directly or view it on GitHub< > > > > https://github.com/wukong-m2m/NanoKong/issues/69#issuecomment-11925063>. > > > > > > — > > > Reply to this email directly or view it on GitHub< > > > https://github.com/wukong-m2m/NanoKong/issues/69#issuecomment-11925114>. > > > > — > > Reply to this email directly or view it on GitHub< > > https://github.com/wukong-m2m/NanoKong/issues/69#issuecomment-11925493>. > > — > Reply to this email directly or view it on GitHubhttps://github.com/wukong-m2m/NanoKong/issues/69#issuecomment-11925603.
wycc commented 11 years ago

However, the component will be duplicated in different page. Is this OK?

2013/1/6 senatorjo notifications@github.com

My understanding is that parser should be able to read from the application.xml and understand it, right? The current implementation is already doing that , it gets every

tag and parse it regardless of the page. Sen On Sat, Jan 5, 2013 at 11:58 PM, Yu-Chung Wang notifications@github.comwrote: > However, this issue is related to multi page parser. Is it implemented? > > 2013/1/6 senatorjo notifications@github.com > > > There are two commits today: > > https://github.com/wukong-m2m/NanoKong/commits/fbp-multipage > > One of them solve the previous problem why fbp-multipage was not > > working > > (native port assignment issue). > > > > Sen > > > > On Sat, Jan 5, 2013 at 10:36 PM, Yu-Chung Wang < > > notifications@github.com>wrote: > > > > > Where is your patch? I don't see it yet. > > > > > > 2013/1/6 senatorjo notifications@github.com > > > > > > > All the components are read regardless of their pages now. Let me > > > > know > > > > if > > > > further changes are needed. > > > > > > > > — > > > > Reply to this email directly or view it on GitHub< > > > > > > https://github.com/wukong-m2m/NanoKong/issues/69#issuecomment-11925063>. > > > > > > > > > — > > > Reply to this email directly or view it on GitHub< > > > https://github.com/wukong-m2m/NanoKong/issues/69#issuecomment-11925114>. > > > > — > > Reply to this email directly or view it on GitHub< > > https://github.com/wukong-m2m/NanoKong/issues/69#issuecomment-11925493>. > > — > Reply to this email directly or view it on GitHub< > https://github.com/wukong-m2m/NanoKong/issues/69#issuecomment-11925603>. — Reply to this email directly or view it on GitHubhttps://github.com/wukong-m2m/NanoKong/issues/69#issuecomment-11925729.
senatorjo commented 11 years ago

Yeah, it happened to be OK, since we saved the components using their instance ID. duplicated instance ID will overwrite the previous one.

But to make it more efficient. I just added some code to omit the later definitions of components of the same instance ID.

Sen

On Sun, Jan 6, 2013 at 12:51 AM, Yu-Chung Wang notifications@github.comwrote:

However, the component will be duplicated in different page. Is this OK?

2013/1/6 senatorjo notifications@github.com

My understanding is that parser should be able to read from the application.xml and understand it, right? The current implementation is already doing that , it gets every

tag and parse it regardless of the page. Sen On Sat, Jan 5, 2013 at 11:58 PM, Yu-Chung Wang notifications@github.comwrote: > However, this issue is related to multi page parser. Is it > implemented? > > 2013/1/6 senatorjo notifications@github.com > > > There are two commits today: > > https://github.com/wukong-m2m/NanoKong/commits/fbp-multipage > > One of them solve the previous problem why fbp-multipage was not > > working > > (native port assignment issue). > > > > Sen > > > > On Sat, Jan 5, 2013 at 10:36 PM, Yu-Chung Wang < > > notifications@github.com>wrote: > > > > > Where is your patch? I don't see it yet. > > > > > > 2013/1/6 senatorjo notifications@github.com > > > > > > > All the components are read regardless of their pages now. Let > > > > me > > > > know > > > > if > > > > further changes are needed. > > > > > > > > — > > > > Reply to this email directly or view it on GitHub< > > > > > > https://github.com/wukong-m2m/NanoKong/issues/69#issuecomment-11925063>. > > > > > > > > > — > > > Reply to this email directly or view it on GitHub< > > > > https://github.com/wukong-m2m/NanoKong/issues/69#issuecomment-11925114>. > > > > > > — > > Reply to this email directly or view it on GitHub< > > https://github.com/wukong-m2m/NanoKong/issues/69#issuecomment-11925493>. > > — > Reply to this email directly or view it on GitHub< > https://github.com/wukong-m2m/NanoKong/issues/69#issuecomment-11925603>. — Reply to this email directly or view it on GitHub< https://github.com/wukong-m2m/NanoKong/issues/69#issuecomment-11925729>.

— Reply to this email directly or view it on GitHubhttps://github.com/wukong-m2m/NanoKong/issues/69#issuecomment-11925901.

senatorjo commented 11 years ago

Just add a hash function to make sure duplicated links will be ignored. The assumption behind the hash function, at most 999 instances, at most 99 properties per instance.