Open pencilcheck opened 11 years ago
Penn,
Thank you for pointing this out. We need to have a code review soon in order to release our code.
Please help to document all the finding and put it in github. We can review and assign the issue later.
Best, Daniel On 2013/03/07, at 下午8:39, Penn Su notifications@github.com wrote:
Right now our standardlibrary has some inconsistency, on one hand we have some simple attributes to indicate what wuclasses and respective available implementations there are in our repository, however right now this not the case for example Threshold. We have specify to have a Java implementation, but in reality there is also a C implementation.
Our program has to deal with this inconsistency and it is annoying, I think we should clear it up and discuss whether if we want to continue with current way find a way to add another tag for native implementation or get rid of implementation and move it to only coming from the node's side.
— Reply to this email directly or view it on GitHub.
Chi-Sheng (Daniel) Shih NEWS Lab, National Taiwan University E-Mail: cshih@csie.ntu.edu.tw
Right now our standardlibrary has some inconsistency, on one hand we have some simple attributes to indicate what wuclasses and respective available implementations there are in our repository, however right now this not the case for example Threshold. We have specify to have a Java implementation, but in reality there is also a C implementation.
Our program has to deal with this inconsistency and it is annoying, I think we should clear it up and discuss whether if we want to continue with current way find a way to add another tag for native implementation or get rid of implementation and move it to only coming from the node's side.