wukong-m2m / wukong-darjeeling

Darjeeling for WuKong
Other
20 stars 17 forks source link

WuClass Editor is still very buggy #29

Open pencilcheck opened 11 years ago

pencilcheck commented 11 years ago

Both global WuClass Editor and application Edit component are both buggy and not working intuitively

First, the edit component will not save the newly created wuclasses if there was no custom wuclasses created before (the Custom 1), and even after I check the checkbox next to the name the xml will not be updated and no WKDeployCustomComponents.xml file will be created.

That's one bug, but there could be more.

Second, the global WuClass Editor if you go to Classes tab and try to create a new wuclass, it will not show you any GUI hint except for a subtle update by adding at the bottom of the list called "New Class", and interestingly, if you don't do anything and keep hitting the "New Class" button, more entries will appear with the same name and if you go in one of the created wuclass and try to change something and exit back out, all new entries with the same name will be checked.

Also, it is not very clear what are created or not by looking at the GUI. In editing new wuclass panel, I can't tell if I am creating a C or a Java, or if both implementations are already created.

wycc commented 11 years ago

I understand that we will have a number of bugs in the WuClass designer. This is why I need somebody to test it.

However, before we go into the UI issues. We need to make sure

(1) Is virtual wuclasses working at all? (2) Is application Custom WuClass working at all?

I can fix the WuClass Designer issues at Tuesday. However, please give us the results for the above two questions as soon as possible. If it does not work, we need to spend a couple of hours in Tuesday to solve it. I will work with you guys for it. HOwever, please dig as much details as possible before the next Tuesday.

2013/9/7 Penn Su notifications@github.com

Both global WuClass Editor and application Edit component are both buggy and not working intuitively

First, the edit component will not save the newly created wuclasses if there was no custom wuclasses created before (the Custom 1), and even after I check the checkbox next to the name the xml will not be updated and no WKDeployCustomComponents.xml file will be created.

That's one bug, but there could be more.

Currently, you need to click the Save button to save the settings. Of course, we can change this to save it immediately after each action. However, please click the save button for now.

Second, the global WuClass Editor if you go to Classes tab and try to create a new wuclass, it will not show you any GUI hint except for a subtle update by adding at the bottom of the list called "New Class", and interestingly, if you don't do anything and keep hitting the "New Class" button, more entries will appear with the same name and if you go in one of the created wuclass and try to change something and exit back out, all new entries with the same name will be checked.

OK, Please log this as a bug.

Also, it is not very clear what are created or not by looking at the GUI. In editing new wuclass panel, I can't tell if I am creating a C or a Java, or if both implementations are already created.

We may need to respect the virtual flag. The Java option should be available only when the virtual is True. This may solve the confusion. However, the mapper should be changed in the same way as well. Please put this in the issue tracker so that we can work on it latter.

Reply to this email directly or view it on GitHubhttps://github.com/wukong-m2m/wukong-darjeeling/issues/29 .

pencilcheck commented 11 years ago

On Sat, Sep 7, 2013 at 4:18 PM, Yu-Chung Wang notifications@github.comwrote:

I understand that we will have a number of bugs in the WuClass designer. This is why I need somebody to test it.

However, before we go into the UI issues. We need to make sure

(1) Is virtual wuclasses working at all? (2) Is application Custom WuClass working at all?

I can fix the WuClass Designer issues at Tuesday. However, please give us the results for the above two questions as soon as possible. If it does not work, we need to spend a couple of hours in Tuesday to solve it. I will work with you guys for it. HOwever, please dig as much details as possible before the next Tuesday.

I have checked the ant builds for WKDeploy and it seems to be calling codegen.py for generating java class from WKDeployCustomComponents.xml before building the dja archives.

And once that is called the generated virtual java wuclass will be placed in the virtual java wuclass dir as specified in the xml.

Basically we just need to make sure that wkdeploy/build.xml and wkpf-app.xml are both working properly, and I believe they are.

The problem with this approach is that virtual java wuclasses in one application will leak into other applications after they are built, but I think that's another issue.

2013/9/7 Penn Su notifications@github.com

Both global WuClass Editor and application Edit component are both buggy and not working intuitively

First, the edit component will not save the newly created wuclasses if there was no custom wuclasses created before (the Custom 1), and even after I check the checkbox next to the name the xml will not be updated and no WKDeployCustomComponents.xml file will be created.

That's one bug, but there could be more.

Currently, you need to click the Save button to save the settings. Of course, we can change this to save it immediately after each action. However, please click the save button for now.

Where is the save button? I only see save for types, not for wuclasses.

Second, the global WuClass Editor if you go to Classes tab and try to create a new wuclass, it will not show you any GUI hint except for a subtle update by adding at the bottom of the list called "New Class", and interestingly, if you don't do anything and keep hitting the "New Class" button, more entries will appear with the same name and if you go in one of the created wuclass and try to change something and exit back out, all new entries with the same name will be checked.

OK, Please log this as a bug.

Also, it is not very clear what are created or not by looking at the GUI. In editing new wuclass panel, I can't tell if I am creating a C or a Java, or if both implementations are already created.

We may need to respect the virtual flag. The Java option should be available only when the virtual is True. This may solve the confusion. However, the mapper should be changed in the same way as well. Please put this in the issue tracker so that we can work on it latter.

Sure.

Reply to this email directly or view it on GitHub< https://github.com/wukong-m2m/wukong-darjeeling/issues/29> .

— Reply to this email directly or view it on GitHubhttps://github.com/wukong-m2m/wukong-darjeeling/issues/29#issuecomment-23985046 .

wycc commented 11 years ago

2013/9/7 Penn Su notifications@github.com

On Sat, Sep 7, 2013 at 4:18 PM, Yu-Chung Wang notifications@github.comwrote:

I understand that we will have a number of bugs in the WuClass designer. This is why I need somebody to test it.

However, before we go into the UI issues. We need to make sure

(1) Is virtual wuclasses working at all? (2) Is application Custom WuClass working at all?

I can fix the WuClass Designer issues at Tuesday. However, please give us the results for the above two questions as soon as possible. If it does not work, we need to spend a couple of hours in Tuesday to solve it. I will work with you guys for it. HOwever, please dig as much details as possible before the next Tuesday.

I have checked the ant builds for WKDeploy and it seems to be calling codegen.py for generating java class from WKDeployCustomComponents.xml before building the dja archives.

And once that is called the generated virtual java wuclass will be placed in the virtual java wuclass dir as specified in the xml.

Basically we just need to make sure that wkdeploy/build.xml and wkpf-app.xml are both working properly, and I believe they are.

The problem with this approach is that virtual java wuclasses in one application will leak into other applications after they are built, but I think that's another issue.

Please post this another issue. We need to do a clean in the codegen.

2013/9/7 Penn Su notifications@github.com

Both global WuClass Editor and application Edit component are both buggy and not working intuitively

First, the edit component will not save the newly created wuclasses if there was no custom wuclasses created before (the Custom 1), and even after I check the checkbox next to the name the xml will not be updated and no WKDeployCustomComponents.xml file will be created.

That's one bug, but there could be more.

Currently, you need to click the Save button to save the settings. Of course, we can change this to save it immediately after each action. However, please click the save button for now.

Where is the save button? I only see save for types, not for wuclasses.

The Save in the Type will save everything. This is kind of strange. We may remove the Save button latter. However, please use it for now.

Second, the global WuClass Editor if you go to Classes tab and try to create a new wuclass, it will not show you any GUI hint except for a subtle update by adding at the bottom of the list called "New Class", and interestingly, if you don't do anything and keep hitting the "New Class" button, more entries will appear with the same name and if you go in one of the created wuclass and try to change something and exit back out, all new entries with the same name will be checked.

OK, Please log this as a bug.

Also, it is not very clear what are created or not by looking at the GUI. In editing new wuclass panel, I can't tell if I am creating a C or a Java, or if both implementations are already created.

We may need to respect the virtual flag. The Java option should be available only when the virtual is True. This may solve the confusion. However, the mapper should be changed in the same way as well. Please put this in the issue tracker so that we can work on it latter.

Sure.

Reply to this email directly or view it on GitHub< https://github.com/wukong-m2m/wukong-darjeeling/issues/29> .

— Reply to this email directly or view it on GitHub< https://github.com/wukong-m2m/wukong-darjeeling/issues/29#issuecomment-23985046>

.

— Reply to this email directly or view it on GitHubhttps://github.com/wukong-m2m/wukong-darjeeling/issues/29#issuecomment-23986232 .

wycc commented 11 years ago

Most issues has been addressed. We need to revisit all issues again and close this issue.