wukong-m2m / wukong-darjeeling

Darjeeling for WuKong
Other
20 stars 17 forks source link

Deleting wuclass doesn't work #94

Open nielsreijers opened 10 years ago

nielsreijers commented 10 years ago

There are two problems:

wycc commented 10 years ago

The second one is fine since we decide to delete the wuclass. The problem is how to display it in the FBP editor. We need to the component in different color if the wuclass is not available.

YC

2013/11/4 Niels Reijers notifications@github.com

There are two problems:

  • The generated code is still there after deleting the wuclass
  • The user code is still there after deleting the wuclass. If I fix the first problem (which makes it fail now), it will fail on the user code referring to the now missing generated header file.

— Reply to this email directly or view it on GitHubhttps://github.com/wukong-m2m/wukong-darjeeling/issues/94 .

YC

Phone: 886-2-23516989 Mobile: 0919816155

nielsreijers commented 10 years ago

It's not fine, since the ant script will try to build all C files in the directory. Therefore it may fail if there are old files left over from deleted wuclasses.

On Mon, Nov 4, 2013 at 1:38 PM, Yu-Chung Wang notifications@github.comwrote:

The second one is fine since we decide to delete the wuclass. The problem is how to display it in the FBP editor. We need to the component in different color if the wuclass is not available.

YC

2013/11/4 Niels Reijers notifications@github.com

There are two problems:

  • The generated code is still there after deleting the wuclass
  • The user code is still there after deleting the wuclass. If I fix the first problem (which makes it fail now), it will fail on the user code referring to the now missing generated header file.

— Reply to this email directly or view it on GitHub< https://github.com/wukong-m2m/wukong-darjeeling/issues/94> .

YC

Phone: 886-2-23516989 Mobile: 0919816155

— Reply to this email directly or view it on GitHubhttps://github.com/wukong-m2m/wukong-darjeeling/issues/94#issuecomment-27665356 .

_

wycc commented 10 years ago

I means that it's fine if we delete all files when we delete the wuclass. We can display error message if the build process fail.

2013/11/4 Niels Reijers notifications@github.com

It's not fine, since the ant script will try to build all C files in the directory. Therefore it may fail if there are old files left over from deleted wuclasses.

On Mon, Nov 4, 2013 at 1:38 PM, Yu-Chung Wang notifications@github.comwrote:

The second one is fine since we decide to delete the wuclass. The problem is how to display it in the FBP editor. We need to the component in different color if the wuclass is not available.

YC

2013/11/4 Niels Reijers notifications@github.com

There are two problems:

  • The generated code is still there after deleting the wuclass
  • The user code is still there after deleting the wuclass. If I fix the first problem (which makes it fail now), it will fail on the user code referring to the now missing generated header file.

— Reply to this email directly or view it on GitHub< https://github.com/wukong-m2m/wukong-darjeeling/issues/94> .

YC

Phone: 886-2-23516989 Mobile: 0919816155

— Reply to this email directly or view it on GitHub< https://github.com/wukong-m2m/wukong-darjeeling/issues/94#issuecomment-27665356>

.

_

— Reply to this email directly or view it on GitHubhttps://github.com/wukong-m2m/wukong-darjeeling/issues/94#issuecomment-27666801 .