search

wulfsolter / angular2-signaturepad

Angular2 Component for szimek / signature_pad
MIT License
176 stars 157 forks source link

Update package.json #47

Closed alan345 closed 7 years ago

alan345 commented 7 years ago

Update package signature_pad

wulfsolter commented 7 years ago

Your commit has 33 changed files - most of them from your .idea folder - can you please remove those?

I can't even see what this commit is supposed to do? You're changing readmes and licences... you've committed files that are installed, tracked and handled through npm... The commit messages are very minimal.... Yeah, I'm lost. No idea what this is supposed to do, so closing the PR. Sorry

alan345 commented 7 years ago

Sorry. Only the first commit was supposed to be in the pr. https://github.com/wulfsolter/angular2-signaturepad/pull/47/commits/38ffb4733ed73b1c6d60b07c5c86c279afe8de73

wulfsolter commented 7 years ago

Please create a fresh PR, that clearly states what the PR is doing, not how it is doing it. Yes, I now see the there is a version change in package.json, so maybe as a suggestion the commit and/or PR could be something like "signature_pad@2.3.2 has been released, updating our dependencies"

Thanks heaps for your contribution, hope this fixes your 1/4 bug :) Is a lot easier for me at this point to edit the file itself than create new branch, cherry pick out the single commit, merge etc, kinda defeating the point of git - and lose attribution to you in the process.