wulkano / Aperture

Record the screen on macOS
MIT License
1.23k stars 111 forks source link

Can I specify a target folder and filename for the recording? #33

Closed limoragni closed 5 years ago

limoragni commented 7 years ago

Hey! Great work on this library. I was trying to use Electron own screen recording and this is way more performant. Is there a way to specify the path where I want to save the recording? Would be great if I could pass that as an option when starting the recording. I see you are using the tmp package for creating the directory in a tmp folder. Is there a performance reason behind using a temporary folder and not a custom path?

Thanks!

sindresorhus commented 7 years ago

We record into a temp directory to keep it atomic. No chance for the user to record over an existing recording if do multiple recordings at once. Also it won't leave behind a broken video file for the user if for some reason your code crashes. You can just move the file (fs.renameSync) when it's done recording. I guess we could add a destination option, but it would just do the same underneath.

limoragni commented 7 years ago

Thanks for the quick reply. That makes sense. Yes, I'm doing that, I just thought it was convenient to have it as an option. It would be only a convenience feature. You can close the issue if you think it doesn't add value to the library.