wulkano / Aperture

Record the screen on macOS

MIT License

1.23k stars 111 forks source link

Windows + Linux support [wip] #37

Closed albinekb closed 7 years ago

albinekb commented 7 years ago

Wanted to add windows support, and since #32 was adding linux support, i thought it was best to continue from there.

I don't really like the mpg hack, any suggestions to make that better?

todo

[ ] Audio
[ ] Figure out how to get ffmpeg (Should we ship the ffmpeg binary (.exe)?)

20

sindresorhus commented 7 years ago

(Should we ship the ffmpeg binary (.exe)?)

No, that's too heavy and outside the scope of this plugin. We can add a ffmpegBinary option instead.

sindresorhus commented 7 years ago

Would be better if this PR was just focused on only adding Windows support. There are still unresolved issues with the Linux PR (#32).

sindresorhus commented 7 years ago

I don't really like the mpg hack, any suggestions to make that better?

Why is the mpg hack needed?

sindresorhus commented 7 years ago

For startRecording(), I think we should split each OS code into a separate function and only have the conditional in the actual startRecording() method.

albinekb commented 7 years ago

because if i name the file .mp4, it's still mpg codec/container, don't know how to record straight to mp4, or should we we ok with .mpg on windows? (the files are really tiny)

sindresorhus commented 7 years ago

They need to be recorded directly to .mp4.

albinekb commented 7 years ago

closing this for #38