Closed albinekb closed 6 years ago
@sindresorhus .mp4
was working, but windows media player can't play it 😄 tested with vlc and it works.
Since getAudioSources
is outside the class now, how do you want to handle the ffmpegBinary
there?
Is there any interest in finishing this? I don't use Windows and never will use this lib on windows, but if there are people that want this I could pick it up and finish it. Thoughts?
Not really. I only care about the macOS part. I just reviewed this to be nice.
For now, I don't think we can maintain this without a contributor that has windows. I'll be building a PC at some point this year and then I can maintain it, but for now I don't think we can support it properly. 😢
EDIT: There are people who want this (see our most popular Kap issue) but no one interested in maintaining it. It has to go hand-in-hand.
I just did this to be nice too 😄 But as I use macOS as my main OS, I can't really maintain it.
Should I let this PR be open, and wait for someone to come along (windows maintainer) or close it?
Edit: do you want to find a windows maintainer for this? Should we look over in the kap issue maybe if someone is willing to take this?
I'll close this. @albinekb Can you open an issue instead here about adding Windows support? And link to this PR as a starting point.
I use Windows as my main OS besides Arch Linux and could try to pick this up if you guys want me to. (And extend it further with Linux later)
At this point we won't be expanding the scope of Kap, however, if there was a high quality unofficial fork with support for another OS I'd argue that we should link to that. The reasoning being that maintaining this and any comparable open-source project is a lot of work, and the interest for most stops at the idea of doing it. Additionally, the insight we have tells us that Windows and Linux support will require more work with less people benefitting from it.
@skllcrn
with less people benefitting from it. is purely wrong. I couldn't find a good free screen recording app for Windows. At the moment I use ShareX which works fine but it's a UI nightmare. At work I use Kap on macOS. Love it and would really like to see it coming to Windows.
It's always great to hear from people that would like Kap on Windows. We'd love to see someone fork Kap and port it to Windows @levrik! To show your interest your can leave a 👍 on #46 and https://github.com/wulkano/kap/issues/456.
+1 for Windows support @skllcrn @albinekb. Gamedevs would thank you.
Right now your options for free recording on Windows are Windows Game Recorder (built in) or Streamlams / OBS. Both are less than ideal for recording promo videos and product walkthroughs.
Thanks for your comment @shawwn, but please refrain from posting "+1" and use 👍 on the related issues instead. When you do that we can sort issues based on reactions, making your voice heard and helping us prioritise. Remember that we work on a lot of projects, some of us in the tens and hundreds, and every single +1 is a notification/activity log item that just causes noise.
To show your interest your can leave a 👍 on #46 and wulkano/kap#456.
37 without linux support
todo