search

wulkano / Aperture

Record the screen on macOS
MIT License
1.24k stars 111 forks source link

Use the new Decodable Swift protocol to handle options #48

Closed sindresorhus closed 6 years ago

sindresorhus commented 7 years ago

Fixes #8

Much more readable code and we get automatic input validation in the Swift binary.

sindresorhus commented 7 years ago

@LarsJK Would appreciate a review here if you have time and interest. Especially the TODO comments.

sindresorhus commented 6 years ago

Thanks for the feedback @LarsJK ✨ I think I've addressed your concerns now.

I'm gonna go ahead and merge as I need to do more changes based on this, but let me know if you see anything else that could be improved.

sindresorhus commented 6 years ago

I opened a new issue for improving the constructor: https://github.com/wulkano/aperture/issues/50 It's not really related to this work.