search

wulkano / Aperture

Record the screen on macOS
MIT License
1.23k stars 111 forks source link

Add `movieFragmentInterval` option #67

Closed drag0s closed 4 years ago

drag0s commented 5 years ago

Add option to customize movieFragmentInterval. The default will be the same as before (.invalid)

Probably it didn't worked before because you were trying with mp4 containers, but it does work with mov containers and it's nice to be able to change this option.

sindresorhus commented 5 years ago

but it does work with mov containers and it's nice to be able to change this option.

How are you using a mov container with Aperture?

skllcrn commented 4 years ago

Checking in @drag0s, would you still like to continue on this implementation?

drag0s commented 4 years ago

Hey there, sorry for my delayed response.

How are you using a mov container with Aperture?

I use a mov container with Aperture saying that the destination path is a file ending in .mov.

The main problem about not using movieFragmentInterval is that if, in this case the Aperture process, would crash, is killed or terminated for whatever reason; you would have an unusable output movie file.

In the case of using movieFragmentInterval with mov containers you would have a usable mov file that you could watch because was periodically inserting (every movieFragmentInterval) "movie fragments" into the output file, hence you could watch the movie up to the point where the last fragment was written.

movieFragmentInterval doesn't work well with mp4 files

Checking in @drag0s, would you still like to continue on this implementation?

Yes, as long as you guys think it's worth adding it!

sindresorhus commented 4 years ago

I didn't realize the API automatically chose the correct container based on the output URL extension. Do we even need an option at all? Can't we just use movieFragmentInterval when the output URL extension is mov? (And also document that of course)