search

wulkano / Kap

An open-source screen recorder built with web technology
https://getkap.co
MIT License
17.82k stars 818 forks source link

Kap 3.5.1 arm64 DMG still bundles x86 ffmpeg-static & gifsicle #1061

Open psobolewskiPhD opened 2 years ago

psobolewskiPhD commented 2 years ago

macOS version: ProductName: macOS ProductVersion: 12.0.1 BuildVersion: 21A559 Kap version: 3.5.1

Steps to reproduce

lipo -info /Applications/Kap.app/Contents/Resources/app.asar.unpacked/node_mdules/ffmpeg-static/ffmpeg lipo -info /Applications/Kap.app/Contents/Resources/app.asar.unpacked/node_modules/gifsicle/vendor/gifsicle

Current behaviour

Non-fat file: /Applications/Kap.app/Contents/Resources/app.asar.unpacked/node_modules/ffmpeg-static/ffmpeg is architecture: x86_64

Non-fat file: /Applications/Kap.app/Contents/Resources/app.asar.unpacked/node_modules/gifsicle/vendor/gifsicle is architecture: x86_64

Expected behaviour

Expect arm64 ffmpeg binary.

Workaround

Symlink homebrew binaries as described here: https://github.com/wulkano/Kap/issues/970#issuecomment-970097099

Edit: Ironically, brew install kap also bundles the x86 ffmpeg and gifsicle.

psobolewskiPhD commented 2 years ago

Seems like this may help solve the issue? https://github.com/eugeneware/ffmpeg-static/issues/35#issuecomment-631003066 ...at least in case of ffmpeg-static.

psobolewskiPhD commented 1 year ago

Bumping this, still the case for Kap 3.6.0