search

wulkano / Kap

An open-source screen recorder built with web technology
https://getkap.co
MIT License
18.08k stars 825 forks source link

Encoding artifacts #678

Open onordbo opened 5 years ago

onordbo commented 5 years ago

macOS version: macOS 10.14.1 (18B75) Kap version: 3.0.0 - beta5 Mac Model: Macbook Pro 15-inch, 2017 FPS Setting: 30FPS

Steps to reproduce

1) Make a recording 2) Bug shows up in editor

Current behaviour

On occasion recordings in Kap Beta produce some kind of artifact, assumingly from some kind of encoding issue.

Attached Kapture for reference. (Notice the bottom edge) Kapture 2019-05-28 at 11 59 29

sindresorhus commented 5 years ago

How often can you reproduce it?

Can you attach the original video to the issue? (Needs to be zipped)

macOS version: macOS 10.14.1 (18B75)

Maybe try updating to 10.14.5? Could have been fixed in macOS.

onordbo commented 5 years ago

How often can you reproduce it?

Can you attach the original video to the issue? (Needs to be zipped)

macOS version: macOS 10.14.1 (18B75)

Maybe try updating to 10.14.5? Could have been fixed in macOS.

Attached file.

jkelroy commented 5 years ago

I am on macOS 10.14.5 and have seen this a few times. Can't repro but will attach the original gif next time I see it.

karaggeorge commented 5 years ago

I was able to reproduce this too (it happened like 50% of my recordings) on a new (2019) Macbook Pro running 10.14.5

Never actually saw this happen on my 2013 macbook.

I might be able to debug it better, now that I can repro

karaggeorge commented 5 years ago

I was able to get consistent STR for this issue. Seems to happen every time for me if I'm recording at 30 FPS and HEVC encoding.

Reason I couldn't repro in my old laptop is because it didn't support HEVC at all, so it never happened. Right now, we record HEVC by default if the hardware supports it (no option). When I'm at 60 FPS recording show up fine, when I switch to 30 FPS, I seem to get that in every recording (in the original file too, not just the converted one we create for the preview).

When I commented out the HEVC option in the code, I tried both 30 FPS and 60 FPS and it worked fine.

I can see three possible options for now until we figure out what's happening on Aperture side, either create an option in the settings to enable/disable HEVC, disable it all-together until we (or Apple) find a fix for it, or force 60 FPS for recordings if we use HEVC (so if the hardware supports it).

cc @sindresorhus @skllcrn

sindresorhus commented 5 years ago

@karaggeorge Can you reproduce it if you run https://github.com/wulkano/aperture-node/blob/master/example.js?