search

wuminzhe / scale_rb

MIT License
4 stars 2 forks source link

Namespace all classes #3

Closed oskargargas closed 3 months ago

oskargargas commented 1 year ago

Hi! First of all thanks for your work. It's much appreciated. If it's ok, I'll raise few issues as I try to incorporate your library into my codebase.

First thing I noticed are classes outside ScaleRb namespace. In my project I have Address class which represents regular street addresses. After adding this gem it was extended with cryptoaddress methods. This might lead to name collision and other problems.

wuminzhe commented 1 year ago

sorry for late, I will fix this

wuminzhe commented 1 year ago

@oskargargas I have moved all things to the ScaleRb namespace. you can try 0.2.0

you can email me(wuminzhe@gmail.com) or find me on discord with _akiwu