search

wummel / dosage

dosage is a comic strip downloader and archiver
http://wummel.github.io/dosage/
MIT License
51 stars 15 forks source link

HTML output causes crash #78

Open phasormaster opened 9 years ago

phasormaster commented 9 years ago

Running dosage with the HTML output option more than once per day will crash it. This becomes a problem when trying to download comic archives in multiple batches. A simple solution would be to add hours and minutes to the timestamp in the HTML file name.

<type 'exceptions.ValueError'> output file '[HOME]/Downloads/Comics/html/comics-20140827.html' already exists
Traceback (most recent call last):
  File "/usr/bin/dosage", line 487, in main
    res = run(options)
  File "/usr/bin/dosage", line 357, in run
    return getComics(options)
  File "/usr/bin/dosage", line 251, in getComics
    events.getHandler().start()
  File "/usr/lib/python2.7/dist-packages/dosagelib/events.py", line 307, in start
    handler.start()
  File "/usr/lib/python2.7/dist-packages/dosagelib/events.py", line 158, in start
    raise ValueError('output file %r already exists' % fn)
ValueError: output file '[HOME]/Downloads/Comics/html/comics-20140827.html' already exists
System info:
Dosage 2.12
Python 2.7.6 (default, Mar 22 2014, 22:59:56) 
[GCC 4.8.2] on linux2
Local time: 2014-08-27 11:50:59-005
sys.argv ['/usr/bin/dosage', '--output=html', '--output=json', '--all', '--timestamps', 'SluggyFreelance:000726']
LANGUAGE = 'en_US'
LANG = 'en_US.UTF-8'
wummel commented 9 years ago

We believe that the issue you reported is fixed in the source repository of dosage which can be found under: https://github.com/wummel/dosage

Changelog entry:

Thank you for reporting the issue. It is now marked as fixed. If you believe that the issue is not fixed appropriately just add a comment to this issue.