Use LooseVersion to compare requests versions

wummel / linkchecker

check links in web documents or full websites

http://wummel.github.io/linkchecker/

GNU General Public License v2.0

1.42k stars 234 forks source link

Closed jenshnielsen closed 7 years ago

jenshnielsen commented 8 years ago

This makes sure that 2.10.0 > 2.2.0 as expected. Closes #649

charford commented 8 years ago

+1 I ran into this issue today. Had to force install requests 2.9.2 instead of latest (2.10.0) to make it work in the meantime.

astrofrog commented 8 years ago

+1, please merge this and release again soon!

Habbie commented 8 years ago

Had a failing build due to this again today. Can you please consider merging this? Thank you!

anatolykazantsev commented 8 years ago

This is really booboo. The bug poped up in current Debian testing :-(

mgedmin commented 8 years ago

A different fix was committed in c2ce810c3fb00b895a841a7be6b2e78c64e7b042.

anatolykazantsev commented 8 years ago

@mgedmin thanks for notifying!

anarcat commented 7 years ago

please reroll this PR in the new organisation here: https://github.com/linkcheck/linkchecker/pulls see #686 for details

Habbie commented 7 years ago

Given c2ce810, shouldn't we just close this?

anarcat commented 7 years ago

sure but only @jenshnielsen and @wummel can do that...

jenshnielsen commented 7 years ago

Sure I have closed this