search

wummel / linkchecker

check links in web documents or full websites
http://wummel.github.io/linkchecker/
GNU General Public License v2.0
1.42k stars 234 forks source link

Fix semver version check for requests #657

Open billonahill opened 8 years ago

billonahill commented 8 years ago

Currently the check that requests version 2.10.0 >= 2.2.0 fails, since the check is using string comparison instead of numeric.

jenshnielsen commented 8 years ago

This is a duplicate of #650 which IMHO is the standard way of doing this and much simpler

billonahill commented 8 years ago

That's great. Any plans to merge #650 and make a release?

jenshnielsen commented 8 years ago

I'm not a maintainer so I can't tell you. I submitted #650 when linkcheker broke for us in the matplotlib docs build on Travis CI, I would like to see it merged and a new release too.

mgedmin commented 8 years ago

This was fixed differently in c2ce810c3fb00b895a841a7be6b2e78c64e7b042.

anarcat commented 7 years ago

please reroll this PR in the new organisation here: https://github.com/linkcheck/linkchecker/pulls see #686 for details

mgedmin commented 7 years ago

This PR should be closed since it fixes a bug already fixed in master.