fix: Made User field optional in History to allow deserialization when missing

wunderfrucht / gouqi

a rust interface for jira

https://crates.io/crates/gouqi

MIT License

26 stars 8 forks source link

fix: Made User field optional in History to allow deserialization when missing #38

Closed junbl closed 1 year ago

junbl commented 1 year ago

In our Jira instance, deserialization of the Changelog field was failing due to missing users (potentially deactivated accounts). Made that field optional to allow deserialization in that case.

what-the-diff[bot] commented 1 year ago

PR Summary

Change of Board struct The Board struct was updated from Copy to Clone, allowing for more efficient and flexible use in the code.
Update of User name field The User name field was modified from String to Option, providing better handling of situations where the name might not be available or necessary.

codecov[bot] commented 1 year ago

Codecov Report

Merging #38 (a6288e5) into main (c28c617) will increase coverage by 0.23%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   14.53%   14.77%   +0.23%     
==========================================
  Files          19       19              
  Lines        3014     3026      +12     
==========================================
+ Hits          438      447       +9     
- Misses       2576     2579       +3

Impacted Files	Coverage Δ
src/rep.rs	`23.33% <ø> (ø)`

... and 2 files with indirect coverage changes

avrabe commented 1 year ago

LGTM. The problem during the build comes from an existing issue.