Closed jthacker closed 1 year ago
Modification of Jira struct in lib.rs file The core structure for Jira management in our main library file has been adjusted.
Change in visibility of 'delete' method The 'delete' method was initially only accessible within its module. It is now publicly accessible, allowing other parts of the program to use this functionality.
Change in visibility of 'get' method Similar to the 'delete' method, the 'get' method's accessibility has been expanded from private to public, offering easier data retrieval across the codebase.
Change in visibility of 'post' method This update enables wider access to the 'post' method, making it easier for other program components to post updates.
Change in visibility of 'put' method The modification of the 'put' method visibility from private to public enhances data update capabilities across different program parts.
Merging #43 (6d17620) into main (39ea88b) will not change coverage. The diff coverage is
50.00%
.
@@ Coverage Diff @@
## main #43 +/- ##
=======================================
Coverage 15.04% 15.04%
=======================================
Files 19 19
Lines 3031 3031
=======================================
Hits 456 456
Misses 2575 2575
Impacted Files | Coverage Δ | |
---|---|---|
src/lib.rs | 12.11% <50.00%> (ø) |
LGTM. I'm fine with opening up the request directly.
Not all end points are implemented in this library and as new ones are added in Jira, clients may lag behind. As such, a helpful stop gap is to make the request methods available, i.e.
get
,put
,delete
,post
. These automatically take care of managing credentials and provide the right API for serialization and deserialization. One example of how to approach this is octocrab.This implementation takes the simplest approach, just make the public. Another approach, but a bit more work would be to namespace them. For example, add a
.api
object toJira
or similar to not pollute the Jira namespace too much. Open to other ideas too.