wunderfrucht / gouqi

a rust interface for jira
https://crates.io/crates/gouqi
MIT License
26 stars 8 forks source link

Public http request methods: get, put, post, delete #43

Closed jthacker closed 1 year ago

jthacker commented 1 year ago

Not all end points are implemented in this library and as new ones are added in Jira, clients may lag behind. As such, a helpful stop gap is to make the request methods available, i.e. get, put, delete, post. These automatically take care of managing credentials and provide the right API for serialization and deserialization. One example of how to approach this is octocrab.

This implementation takes the simplest approach, just make the public. Another approach, but a bit more work would be to namespace them. For example, add a .api object to Jira or similar to not pollute the Jira namespace too much. Open to other ideas too.

what-the-diff[bot] commented 1 year ago

PR Summary

codecov[bot] commented 1 year ago

Codecov Report

Merging #43 (6d17620) into main (39ea88b) will not change coverage. The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   15.04%   15.04%           
=======================================
  Files          19       19           
  Lines        3031     3031           
=======================================
  Hits          456      456           
  Misses       2575     2575           
Impacted Files Coverage Δ
src/lib.rs 12.11% <50.00%> (ø)
avrabe commented 1 year ago

LGTM. I'm fine with opening up the request directly.