wundergraph / cosmo

The open-source solution to building, maintaining, and collaborating on GraphQL Federation at Scale. The alternative to Apollo Studio and GraphOS.
https://cosmo-docs.wundergraph.com/
Apache License 2.0
720 stars 103 forks source link

Removing Lint rules breaks CLI check command #988

Closed YassineElbouchaibi closed 2 months ago

YassineElbouchaibi commented 3 months ago

v0.93.1 removed linting rule REQUIRE_DEPRECATION_DATE. As a consequence the wgc subgraph check command started failing. Looking at the controlplane logs, it is not able to resolve the relevant definition for that rule as it still exists in DB but not in the code. The command fails with internal error code 13. The rule cannot be disabled from the studio UI as it doesn't exist there anymore. To workaround the issue I manually dropped the entry from the DB in the namespace_lint_check_config table. Going forward I would suggest dropping dead rules from the DB in the DB migrations.

Note: Sorry about formatting, I am using github mobile

github-actions[bot] commented 3 months ago

WunderGraph commits fully to Open Source and we want to make sure that we can help you as fast as possible. The roadmap is driven by our customers and we have to prioritize issues that are important to them. You can influence the priority by becoming a customer. Please contact us here.

StarpTech commented 2 months ago

Hi @YassineElbouchaibi, thanks for bringing this to our attention. Your observation is correct. In this situation, a migration was not included. Your fix is sufficient.