fix: goroutine leak and deadlock in ws event loop

wundergraph / graphql-go-tools

GraphQL Router / API Gateway framework written in Golang, focussing on correctness, extensibility, and high-performance. Supports Federation v1 & v2, Subscriptions & more.

https://graphql-api-gateway.com

MIT License

685 stars 129 forks source link

fix: goroutine leak and deadlock in ws event loop #905

Closed StarpTech closed 5 days ago

StarpTech commented 5 days ago

This PR fixes

Remove pond worker and unnecessary mutex locks to avoid deadlock in event loop. A semaphore has been introduced to limit concurrency.
goroutine leak in the websocket origin handlers. We did not abort readBlocking on context cancellation.