search

wunderio / code-quality

List of tools that aims to help with static code quality inspection.
GNU General Public License v3.0
2 stars 5 forks source link

#106 Change yaml, json and check_file_permissions task default paths #107

Closed hkirsman closed 1 month ago

hkirsman commented 6 months ago

Overview

Currently the defaults are quite loose which is [.] folder. There was issue in one of our first project changing to Code Quality 3.x because of that - test just died. After setting the paths for all tasks, tests went through https://github.com/wunderio/client-fi-tre3-content-machine/pull/1468/commits/e1fef73e79b52e73612c75bb9c6e3c88836b14e8

Instead of fixing every project one by one, this PR changes the defaults in base config. This means if task in project is set up with defaults (~), then the issue is gone.

Screenshots

image

Testing

  1. Include this version of Code Quality

    lando composer require wunderio/code-quality:dev-hotfix/106-Change-yaml-and-json-task-default-paths --dev

  2. Run Grumphp to check everything works

lando grumph run

  1. Also, here's the project PR https://github.com/wunderio/client-fi-tre3-content-machine/pull/1468 where I changed to this version and reverted grumphp changes.