search

wunderio / code-quality

List of tools that aims to help with static code quality inspection.
GNU General Public License v3.0
2 stars 5 forks source link

Legacy support #41

Open hkirsman opened 4 years ago

hkirsman commented 4 years ago

We still have old projects and wondering how to support these. One way is using Docker as we're already using Lando so my first idea is to create Docker image that has PHP and other dependencies installed, this can then be used in Lando.

This could be also solution for fixing any dependencies that host needs that where discussed in https://github.com/wunderio/drupal-project/issues/88

hkirsman commented 4 years ago

My example .lando.yml running PHP 5.6:

name: example

recipe: drupal7

config:
  webroot: web
  php: '5.6'

services:
  codequality:
    type: compose
    services:
      image: hkirsman/code-quality
      command: tail -f /dev/null

tooling:
  grumphp:
    service: codequality
    description: Runs GrumPHP commands
    cmd: "cd /app && ./vendor/bin/grumphp"
  git:
    service: codequality
    description: Run GIT inside Lando so Code Quality tool would not require host PHP

Install Code Quality:

lando ssh --service=codequality -c "composer require wunderio/code-quality --dev"

Commit code with lando git commit. This would still need some investigation why @aleksijohansson had diffferent git status inside Lando and in host.

aleksijohansson commented 4 years ago

The issue with lando git seems to be a slowness issue with a Windows host: image