search

wunderio / code-quality

List of tools that aims to help with static code quality inspection.
GNU General Public License v3.0
2 stars 5 forks source link

Vendor folder being scanned with version 1.0.6 #45

Open hkirsman opened 4 years ago

hkirsman commented 4 years ago

I installed it fresh with this command:

php -d extension=iconv.so $(which composer) require wunderio/code-quality   --dev

After commiting, I get:

➜   git commit
GrumPHP detected a pre-commit command.
GrumPHP is sniffing your code!✔
Running task 2/8: PhpcsTask... ✔✔
Running task 4/8: PhpCheckSyntaxTask... ✔✔✘
Aborted ...
PHPStan crashed in the previous run probably because of excessive memory consumption.
It consumed around 55 MB of memory.

To avoid this issue, allow to use more memory with the --memory-limit option.
PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in /home/hannes/Sites/download_d8/vendor/drush/drush/includes/sitealias.inc on line 175
Deprecated: Array and string offset access syntax with curly braces is deprecated in /home/hannes/Sites/download_d8/vendor/drush/drush/includes/sitealias.inc on line 175
PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in /home/hannes/Sites/download_d8/vendor/drush/drush/includes/sitealias.inc on line 176
Deprecated: Array and string offset access syntax with curly braces is deprecated in /home/hannes/Sites/download_d8/vendor/drush/drush/includes/sitealias.inc on line 176
PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in /home/hannes/Sites/download_d8/vendor/drush/drush/includes/command.inc on line 860
Deprecated: Array and string offset access syntax with curly braces is deprecated in /home/hannes/Sites/download_d8/vendor/drush/drush/includes/command.inc on line 860
PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in /home/hannes/Sites/download_d8/vendor/drush/drush/includes/command.inc on line 862
Deprecated: Array and string offset access syntax with curly braces is deprecated in /home/hannes/Sites/download_d8/vendor/drush/drush/includes/command.inc on line 862
PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in /home/hannes/Sites/download_d8/vendor/drush/drush/includes/command.inc on line 873
Deprecated: Array and string offset access syntax with curly braces is deprecated in /home/hannes/Sites/download_d8/vendor/drush/drush/includes/command.inc on line 873

In File.php line 208:

  Failed to open stream hoa://Library/Regex/Grammar.pp.  

analyse [--paths-file PATHS-FILE] [-c|--configuration CONFIGURATION] [-l|--level LEVEL] [--no-progress] [--debug] [-a|--autoload-file AUTOLOAD-FILE] [--error-format ERROR-FORMAT] [--memory-limit MEMORY-LIMIT] [--xdebug] [--] [<paths>...]
To skip commit checks, add -n or --no-verify flag to commit command

When remove composer.lock and vendor, then install with specific (previous) version, it works:

php -d extension=iconv.so $(which composer) require wunderio/code-quality:1.0.5   --dev

➜   git commit
GrumPHP detected a pre-commit command.
GrumPHP is sniffing your code!✔
Running task 2/8: PhpcsTask... ✔✔
Running task 4/8: PhpCheckSyntaxTask... ✔✔✘
Aborted ...
------ -------------------------------------------------------------- 
  Line   src/EventSubscriber/ConfigEventSubscriber.php                 
 ------ -------------------------------------------------------------- 
         Internal error: Call to a member function yes() on bool       
         Run PHPStan with --debug option and post the stack trace to:  
         https://github.com/phpstan/phpstan/issues/new                 
 ------ --------------------------------------------------------------

I assume we missed this because we didn't install on clean project (without Code Quality previously installed)

hkirsman commented 4 years ago

Actually it's not working. 

Internal error: Call to a member function yes() on bool       
Run PHPStan with --debug option and post the stack trace to:  
https://github.com/phpstan/phpstan/issues/new

It's different but not ok also. So not sure what is going on.

hkirsman commented 4 years ago

Problem still exists in latest 1.0.9. I think this is related to https://github.com/wunderio/code-quality/issues/51 and could be solved after fix is done there.

@guncha25 

lando grumphp run
GrumPHP is sniffing your code!
Running task 1/8: EcsTask... ✔
Running task 2/8: PhpcsTask... ✔
Running task 3/8: PhpCompatibilityTask... 
In Process.php line 1330:

  The process "'/app/vendor/bin/phpcs' '--extensions=php,inc,module,install,theme' '--parallel=20' '--runtime-set' 'testVersion' '7.3' '--standard=PHPCompatibility' '--basepath=.' '-s' 'testing'" exceeded the timeout of 60 seconds.
guncha25 commented 4 years ago

@hkirsman Agree. Ignore folders are top priority.