Closed tormi closed 6 months ago
Thanks, @misterjoonas! I updated the regex according to the link you provided. I also updated the testing section in the PR description.
Please consider how this change will affect possible outside contributors who don't have access to your internal JIRA
@badrange, good point when considering this particular template project!
Please consider how this change will affect possible outside contributors who don't have access to your internal JIRA
@badrange - It looks like we can use the GH-<issue number>
syntax for this, similar to issue numbers in JIRA, see Issues and Pull Requests:
GH- and issue or pull request number GH-26 [GH-26](https://github.com/jlord/sheetsee.js/issues/26)
The same regex applies as for JIRA issues. I'll include some instructions on this in the readme.
Thanks, @misterjoonas & @badrange!
That was a clever solution!
Ticket: WD-253
Changes
This PR introduces JIRA ticket number validation in GIT commit messages via GrumPHP git_commit_message task.
General JIRA ticket code regex is implemented as a default rule:
/^[A-Z][A-Z0-9_]+-[1-9][0-9]*: /
.When implementing in a specific project, the name of the JIRA project should be specified. For example, the regex for a project called WD would be:
/^WD-[1-9][0-9]*: /
.Testing
LA004311-3325:
. It should pass.