search

wunderio / image-fuzzy-alpine-devshell

https://quay.io/repository/wunder/fuzzy-alpine-devshell
GNU General Public License v3.0
0 stars 1 forks source link

Should we base the image out of wunderkraut/alpine-php? #22

Closed aleksijohansson closed 8 years ago

aleksijohansson commented 8 years ago

I think we should base the image out of https://github.com/wunderkraut/alpine-php, but do you @james-nesbitt remember why this was not done previously? We might still need edge from alpine as the base though.

james-nesbitt commented 8 years ago

Previously we skipped alpine-php because:

  1. we didn't want php-fpm, but rather we wanted php-cli
  2. we wanted more php packages in the dev shell
aleksijohansson commented 8 years ago

@james-nesbitt I think 2 is not an issue, but you're right about 1. If we base this to wunderkraut/alpine-php, we would have php7-fpm which we don't need, but does it really hurt that much?

james-nesbitt commented 8 years ago

no it doesn't hurt. In fact, there may even be an argument for it.

Additionally, we could always remove it in the dockerfile for devshell.

aleksijohansson commented 8 years ago

@james-nesbitt Good point! I'll start to work on a "rebase".

james-nesbitt commented 8 years ago

Merged in #25

aleksijohansson commented 8 years ago

Image based to wunderkraut/alpine-php in #25.