wunderio / radi-cli

CLI interface for the Radi-API

1 stars 2 forks source link

Dependency management should pull specific versions of dependencies #15

Closed james-nesbitt closed 7 years ago

james-nesbitt commented 7 years ago

Currently when the make system builds (both containerized and local), the dependencies pulled are "latest" releases.

This causes breakage when upstream versions undergo API breakage.

james-nesbitt commented 7 years ago

this needs review. I have asked @aleksijohansson but I know that he is on vacation.

james-nesbitt commented 7 years ago

this effort is still underway.

The other repositories now all container decent fixed dependencies via vendor submodules, but this cli repo itself needs a similar update still.

james-nesbitt commented 7 years ago

To clarify:

api and handler external libraries are now fixed and pinned
cli interal libraries are not yet pinned
the cli itself uses 1 library which is not pinned (urfave/cli)

james-nesbitt commented 7 years ago

20 implemented the architecture for this. Now I only need to pick the versions.

james-nesbitt commented 7 years ago

Note that we did have 1 issue related to version pinning, as one of the used libraries doesn't pin it's own libraries: https://github.com/wunderkraut/radi-handler-upcloud/issues/3

james-nesbitt commented 7 years ago

21 delivers the first pinned versions.

james-nesbitt commented 7 years ago

this needs review ( @tharna or @aleksijohansson )

tharna commented 7 years ago

@james-nesbitt is there anything particular still on this one? If the pinning is now there, and we know the exceptions so far I think everything is fine with the concept.

james-nesbitt commented 7 years ago

pinning at the cli level is good. There is no version pinning in the handlers, but version pinning at this level is sufficient for now.