wunderio / radi-cli

CLI interface for the Radi-API
1 stars 2 forks source link

[WIP] Dependency pinning using vendor folders #16

Closed james-nesbitt closed 7 years ago

james-nesbitt commented 7 years ago

This should satisfy https://github.com/wunderkraut/radi-cli/issues/15

This patch pushes a new approach to dependency version pinning, by using a fixed vendor folder. This is in line with modern package management in go app since go 1.6.

In thew new paradigm, verndors are packages as submodules in the repository, and builds do not retrieve dependencies. Dependencies are updated manually, and pushed like any other update to the project repository.

Building the app locally, and using the dockerized build.sh script should work without any issues, and should be a bit faster (no dep retrieval). You can use make update-deps to update dependencies, or update each vendor git project independently. We will probably switch to the go dep tool if it gets mainlined.

Also in this patch is the removal of a large number of script variable references to the previous project name.

james-nesbitt commented 7 years ago

there be sharks

james-nesbitt commented 7 years ago

this is being refactored