wunderio / silta-circleci

A docker image used to run Silta builds on circleCI
1 stars 6 forks source link

Post release step #189

Closed guncha25 closed 5 months ago

guncha25 commented 10 months ago

Add post release steps to Simple and Drupal jobs.

Motivation:

  1. Currently there are edge cases when application rollout is too slow and the time between cache clear and actual updated images are spun up is too large so we need to do additional steps once we know that all replicas have been rolled out. (Error is created for client after each new plugin deployment + template changes since cache clear just cleans cache, but if someone accesses old pod then old cache is regenerated)
  2. We already have pre-release steps so makes sense that we add pos-release "hook"
  3. In future this allows additionally run any step like:
    • Send notifications in same step instead of creating dependant job
    • Make additional deployment validations
    • Run create tunnels and run test only if deployment is successful
    • Trigger other web hooks.
    • Etc.

How it works:

          name: build-deploy-myproject
          post-release:
            - run: kubectl exec -it deploy/${RELEASE_NAME}-shell -n ${CIRCLE_PROJECT_REPONAME,,} -- drush cr
            - run: vendor/bin/codecept run -g ${RELEASE_NAME}
            - run: curl --output /dev/null --silent --head --fail "https://mysite.com";
Jancis commented 9 months ago

@guncha25 , this PR might fix the issue, let's release and test that if it solves Your case: https://github.com/wunderio/silta-cli/pull/54

Rade333 commented 9 months ago

@guncha25 , this PR might fix the issue, let's release and test that if it solves Your case: wunderio/silta-cli#54

@guncha25 I also believe the PR by @Jancis will fix your problem. Please see screenshots here: https://github.com/wunderio/silta-cli/pull/54#pullrequestreview-1832205524

Rade333 commented 9 months ago

@guncha25 did your issue get solved already, or do you still see that this PR is needed?

Rade333 commented 6 months ago

@guncha25 did your issue get solved already, or do you still see that this PR is needed?

@guncha25 any updates on this?

Rade333 commented 5 months ago

Closing due to inactivity.