search

wupdigital / android-maven-publish

Modification of the standard Maven Publish plugin to be compatible with android-library projects (aar).
Apache License 2.0
326 stars 39 forks source link

Compatibility with Gradle 4.8 #19

Closed trevjonez closed 6 years ago

trevjonez commented 6 years ago 
java.lang.AbstractMethodError: digital.wup.android_maven_publish.AndroidVariantLibrary$CompileUsage.getGlobalExcludes()Ljava/util/Set;
        at org.gradle.api.publish.maven.internal.publication.DefaultMavenPublication.populateFromComponent(DefaultMavenPublication.java:246)
        at org.gradle.api.publish.maven.internal.publication.DefaultMavenPublication.getPublishableArtifacts(DefaultMavenPublication.java:357)
        at org.gradle.api.publish.maven.internal.publication.DefaultMavenPublication_Decorated.getPublishableArtifacts(Unknown Source)
        at org.gradle.api.publish.maven.tasks.AbstractPublishToMaven$1.call(AbstractPublishToMaven.java:46)
        at org.gradle.api.publish.maven.tasks.AbstractPublishToMaven$1.call(AbstractPublishToMaven.java:43)
        at org.gradle.util.GUtil.uncheckedCall(GUtil.java:458)
        at org.gradle.api.internal.file.collections.BuildDependenciesOnlyFileCollectionResolveContext.add(BuildDependenciesOnlyFileCollectionResolveContext.java:73)
        at org.gradle.api.internal.file.collections.BuildDependenciesOnlyFileCollectionResolveContext.add(BuildDependenciesOnlyFileCollectionResolveContext.java:75)
        at org.gradle.api.internal.tasks.TaskPropertyFileCollection.visitContents(TaskPropertyFileCollection.java:53)
        at org.gradle.api.internal.file.CompositeFileCollection.visitDependencies(CompositeFileCollection.java:187)
        at org.gradle.api.internal.tasks.CachingTaskDependencyResolveContext$TaskGraphImpl.getNodeValues(CachingTaskDependencyResolveContext.java:89)
        at org.gradle.internal.graph.CachingDirectedGraphWalker$GraphWithEmpyEdges.getNodeValues(CachingDirectedGraphWalker.java:211)
        at org.gradle.internal.graph.CachingDirectedGraphWalker.doSearch(CachingDirectedGraphWalker.java:121)
        at org.gradle.internal.graph.CachingDirectedGraphWalker.findValues(CachingDirectedGraphWalker.java:73)
        at org.gradle.api.internal.tasks.CachingTaskDependencyResolveContext.doGetDependencies(CachingTaskDependencyResolveContext.java:76)
        at org.gradle.api.internal.tasks.CachingTaskDependencyResolveContext.getDependencies(CachingTaskDependencyResolveContext.java:60)
[...]
trevjonez commented 6 years ago

Looks like you already got through #18 & #17 today. I was going to take a swing at this one today as I am really wanting to use the new pom dsl they added in gradle 4.8 but it seems you might already be working on the solution? Let me know, I have a handful of libraries I would love to upgrade to use this plugin asap.

warnyul commented 6 years ago

Yes, I am working on the solution. I would like to release the new version today.

warnyul commented 6 years ago

Soon it will be available in Gradle Plugin portal

trevjonez commented 6 years ago

looks like the upload from travis failed due to a misconfig some where?

warnyul commented 6 years ago

Something wrong with bintrayUpload:

Could not upload to 'https://api.bintray.com/content/[secure]/[secure]-maven/android-maven-publish/3.6.0/value: digital/wup/value: android-maven-publish/value: 3.6.0/value: android-maven-publish-value: 3.6.0.pom': HTTP/1.1 400 Bad Request [message:Unable to upload files: Maven group, artifact or version defined in the pom file do not match the file path 'value: digital/wup/value: android-maven-publish/value: 3.6.0/value: android-maven-publish-value: 3.6.0.pom']

warnyul commented 6 years ago

I am not so happy. This is an open issue on bintray plugin. I can't make release today. I will revert this release and reopen the issue. Until this has been fixed.

trevjonez commented 6 years ago

Looks like they shipped gradle-bintray-plugin:1.8.1 today. I was able to deploy this repo locally and upload my project once I had both 3.6.0 of this plugin and 1.8.1 of theirs.

warnyul commented 6 years ago

Thansks for your help. I have published 3.6.0 with bintray plugin 1.8.1. It is available now.