Non-executable files set with executable permissions

wurmlab / sequenceserver

Intuitive graphical web interface for running BLAST bioinformatics tool (i.e. have your own custom NCBI BLAST site!)

https://sequenceserver.com

GNU Affero General Public License v3.0

270 stars 113 forks source link

Non-executable files set with executable permissions #530

Open mensfeld opened 3 years ago

mensfeld commented 3 years ago

Hey there,

While reviewing the source code of sequenceserver I've noticed, that several files have executable permissions while not being an executables.

For example:

public/js/webshims/shims/styles/widget.eot
public/js/webshims/shims/jme/jme.woff
public/js/webshims/shims/styles/progress.gif
public/js/webshims/shims/jme/jme.svg
# and many more...

is that something intended? If so, I would appreciate explanation as I often find it a bug.

Thank you :pray:

yeban commented 3 years ago

They are bugs. I recently fixed one in a part of the codebase I was working on (5841213c). Feel free to fix some, but I don't see the paths you listed above in my clone of the repo - I hope you are looking at the updated master branch?

mensfeld commented 3 years ago

Thanks @yeban. I've been looking into the RubyGems released package (most recent version).