wurmlab / sequenceserver

Intuitive graphical web interface for running BLAST bioinformatics tool (i.e. have your own custom NCBI BLAST site!)
https://sequenceserver.com
GNU Affero General Public License v3.0
268 stars 111 forks source link

Fix advanced arguments help modal #728

Closed tadast closed 6 months ago

tadast commented 6 months ago

This reverts commit https://github.com/wurmlab/sequenceserver/commit/ecfaa3cde12e970b01ca5cdca8d831b9e42b6f92.

The change had an unintended consequence of disabling the help modal for advanced features.

I'd argue that https://github.com/wurmlab/sequenceserver/issues/695 is a bit misleading - it is expected for HTML labels to be clickable. Clicking on an input field label should focus the input field, which it was doing. I don't think this should change.

It just happens that the help modal trigger is crammed into the label too, so it can perhaps get confusing when the two elements next to each other are clickable and react to the same hover - perhaps the latter needs to change instead? Maybe the trigger icon can move to be inset on the right side of the input field?

ghost commented 6 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/wurmlab/sequenceserver/728/798c7b74/bf5b65c5cc617a862207d79c8eab213e8af4fa19.svg)](https://app.codesee.io/r/reviews?pr=728&src=https%3A%2F%2Fgithub.com%2Fwurmlab%2Fsequenceserver) #### Legend CodeSee Map legend