wurmlab / sequenceserver

Intuitive graphical web interface for running BLAST bioinformatics tool (i.e. have your own custom NCBI BLAST site!)
https://sequenceserver.com
GNU Affero General Public License v3.0
274 stars 114 forks source link

Fix modal edge cases #813

Closed tadast closed 1 month ago

tadast commented 1 month ago

To prevent the body from scrolling under an open modal, there was some JS to add a css class that stops scrolling. However, the HTML <dialog> element allows closing the modal by hitting ESC key on the keyboard. Doing that was not removing the 'overflow-hidden' class from document body, keeping the entire page "stuck" and not scrolling. Use a CSS-only solution instead (cc @3lviend).

Also fix sequence viewer modal with a lot of content by adding max height and scrolling.