wurstmeister / kafka-docker

Dockerfile for Apache Kafka
http://wurstmeister.github.io/kafka-docker/
Apache License 2.0
6.92k stars 2.73k forks source link

Add support for Kafka 3.0.0. #691

Open Jack12816 opened 2 years ago

Jack12816 commented 2 years ago

- What is it good for

Support for Kafka 3.0.0 with the regular ZooKeeper setup.

- What I did

I just added Kafka 3.0.0 as build configuration just like Add support for Kafka 2.8.1 did. A local build was successful, even though I will play around with this locally. I also had to change some Kafka connection options (--zookeeper is deprecated since multiple versions, and since Kafka 3.0 it was removed -- replaced by the --bootstrap-server option) and fix some tests for the new version/outputs.

- A picture of a cute animal (not mandatory but encouraged)

download

loop commented 2 years ago

@wurstmeister what are your thoughts on this?

jimbogithub commented 2 years ago

@loop Can you fix the conflicts and bump to 3.0.1? Keen for a version with https://issues.apache.org/jira/browse/KAFKA-13636 fixed.

lunarfs commented 2 years ago

@Jack12816 What is the plan for getting this over the finishline, potentially (preferred) bumping this to 3.1.0

lunarfs commented 2 years ago

I am working on getting this to work with 3.1.0, until now there is a few fixes that needs to be applied.. will get back in a few days once there is some news

Jack12816 commented 2 years ago

@Jack12816 What is the plan for getting this over the finishline, potentially (preferred) bumping this to 3.1.0

The tests for 3.0.0 still failed in the latest state of this PR. I was working on fixing this, but had no time since then to complete it. I'm also not sure whats the actual issue anymore :S

lunarfs commented 2 years ago

@Jack12816 What is the plan for getting this over the finishline, potentially (preferred) bumping this to 3.1.0

The tests for 3.0.0 still failed in the latest state of this PR. I was working on fixing this, but had no time since then to complete it. I'm also not sure whats the actual issue anymore :S

Ok, I took the liberty of building on top of your work in my own fork. I managed to get the tests green.. I need the 3.x support for a project I am dooing.. So I am willing to try to get this support added to master herer (rather than have to maintain my own fork)

OneCricketeer commented 2 years ago

need the 3.x support for a project I am dooing

Worth mentioning there are other Kafka images that already have 3.x releases