wurstscript / WurstScript

Programming language and toolkit to create Warcraft III Maps
https://wurstlang.org
Apache License 2.0
225 stars 30 forks source link

[Lua] The reserved functions "objectToIndex" and "objectFromIndex" collide with user functions #1053

Open jlfarris91 opened 2 years ago

jlfarris91 commented 2 years ago

image

These two functions are apparently reserved but the developer is unaware. I have a tuple called 'object' in my project and necessarily I created indexing functions 'objectToIndex' and 'objectFromIndex'. Afaik the compiler did not warn me that I shouldn't use these reserved names and ultimately it used my functions instead of the wurst-generated object indexing functions that are generated when using "x castTo int".

Ideally I am able to use them since I can in jass and otherwise I would have to rewrite a large library. Maybe the compiler can detect if those functions have been defined by the user and instead generate different function names?

Or just change the names to something that is less likely to collide with developer code? "objectFromIndex" and "objectToIndex" perhaps?