Closed Cokemonkey11 closed 1 year ago
I guess it could have problems if it builds for wrong patch due to not being able to detect version. But I think it's not configurable right now anyway. Does the warning show in the grill terminal?
@Frotty thanks for the swift review
I don't know if WLogger writes to terminal but I suspect that it only goes to the log file.
You are right that a user on an old patch might now be missing error information in the terminal, but such a user I hope would figure out to check logs
As I said, a better fix would be if w3utils used a different exception. Then we could continue supporting users on an old w3 version while suppressing the error for Linux users? Another option might be to remove the error/warn entirely and just log to the user that the installation version couldn't be found for (reason) and that wurst is building a map file for (default version)
Let me know how much you care about this? My goal was just to do a quick and simple clean up, because I think the exception is useful but only in log file
It may be better to update w3utils to throw a different exception to match against for linux versus a not-found mac/windows one, but this seems like a sensible improvement anyway since wurstc just uses latest patch when the version cannot be determined.
To be clear, when this stacktrace appears, wurstc has no problem building a map successfully.