Game crash when using specific tech tree upgrades in BuildingDefinition

[TheSkullbot]

Describe the bug Creating unit definitions with specific upgrades lead to a game crash when trying to access the building menu of units

Steps to reproduce :

• Create two buildings unit definition in code (by inheriting BuildingDefinition)
• Set each "Upgrades to" (uupt) to the ID of the other building
• Make the units available through a builder unit

OR

• Create a building unit definition in code (by inheriting BuildingDefinition)
• Create a second unit definition, and set it's "Upgrades to" (uupt) to the ID of the first unit
• Create a third unit definition, and set it's "Upgrades to" (uupt) to the ID of the second unit
• Make the third unit available through a builder unit

Code (simplified) example : https://github.com/TheSkullbot/WurstBug

• I have a Campfire building (built with my Founder unit), which can upgrade to Lamp or Torch.
• Lamp can then "upgrade" to Torch, and Torch can also "upgrade" to Lamp (it's basically skin swap)
• Example may lack some imports, but I can provide full repo access on-demand if needed

compiler.log : https://pastebin.com/raw/AY8nSD4x languageServer.log : https://pastebin.com/raw/cXpGHARM

Weird behaviour :
Some buildings works, some others don't 🤷 I can upgrade my lamp into a chicken coop without issue, but not into a Torch Maybe it's related to compiletime order and ID generation ?

[Frotty]

The example misses too much code, please make a concise 1 package example that reproduces the problem.

[TheSkullbot]

I'll try to make a package with only the described problem today 👍

[Frotty]

Yes, please provide a SCCEE. Otherwise it's very hard to rule out side effects from the rest of the code.

[TheSkullbot]

I update the repo https://github.com/TheSkullbot/WurstBug with only the needed code.

I also narrowed the issue to this 2 conditions :

• If a building 1 requires another building (2 or 3)
• If building 2 can upgrade to building 3, and building 3 can "upgrade back" to building 2 Then the game will crash when you open the build menu of the unit who can make building 1.

In the code example : Building 1 : Tent Building 2 : Campfire Building 3 : Lamp

Please also note that I'm using an ObjectIDManager lib to generate ids at compile time Ids are ok in the generated map (x001, x002 & x003)

Hope it helps !

[Frotty]

Does this constellation work in the world editor?

[TheSkullbot]

Hum, good point, it doesn't work in the world editor either. I should have tried it before posting. So, definetely not a Wurst issue, can be closed :)

Unrelated but, do you guys know where to find the crash logs for reforged ?

[Frotty]

Hum, good point, it doesn't work in the world editor either.

😅 Good to know, might be useful to add as comment to stdlib source/doc pages.

Unrelated but, do you guys know where to find the crash logs for reforged ?

Nope. I just know that classic crash logs were never really useful to modders.