Merge PTR branch into master

wurstscript / WurstStdlib2

WurstScript Standard Library Version 2

Apache License 2.0

55 stars 53 forks source link

Merge PTR branch into master #250

Closed Frotty closed 5 years ago

Frotty commented 5 years ago

@Krypt0n @Donach @WareditorGit @fe3dback As a followup to https://github.com/wurstscript/WurstStdlib2/issues/228 Now that 1.31 is live, the PTR branch should be merged as soon as the PRs are done.

These are mising:

WareditorGit commented 5 years ago

I will work on DamageEvent.

Donach commented 5 years ago

Hello @Frotty About #245 , can you check it? There should be no more open points, although it might use another review (if you didn't already). Thanks.

EDIT: Since its just adding stuff, it should not break anything, but the get/set functions in the new TriggerData might need some renaming, I just used whatever seemed to be most logical to me.

Frotty commented 5 years ago

I will work on DamageEvent.

Maybe make a new ticket for that then? What exactly needs to be changed?

Anyway, ptr is merged, cheers 🍻