Related to #297
1.29 patch brought the effect-orientation control to the game. It used Euler-angles in order X-Y-Z which was quite confusing according to names Yaw-Pitch-Roll. In the latest patches this was changed. Now, Yaw defines rotation around Z axis and Roll defines rotation around X axis and the rotation order (according to Yaw-Pitch-Roll) has become Z-Y-X.
This PR fixes the issues in the standard library which appeared with the game's changes. Thanks to Blizzard for non-mentioning these changes in the patch notes so it took me a while to notice the problem.
Tests succeeded: 22/22
>> All tests have passed successfully!
Tests succeeded: 35/35
>> All tests have passed successfully!
Frotty
commented
5 years ago
Related to #297 1.29 patch brought the effect-orientation control to the game. It used Euler-angles in order
X-Y-Zwhich was quite confusing according to namesYaw-Pitch-Roll. In the latest patches this was changed. Now,Yawdefines rotation aroundZaxis andRolldefines rotation aroundXaxis and the rotation order (according toYaw-Pitch-Roll) has becomeZ-Y-X. This PR fixes the issues in the standard library which appeared with the game's changes. Thanks to Blizzard for non-mentioning these changes in the patch notes so it took me a while to notice the problem.