search

wurstscript / WurstStdlib2

WurstScript Standard Library Version 2
Apache License 2.0
55 stars 53 forks source link

Adapt StdLib to new typeclass features #343

Open peq opened 4 years ago

peq commented 4 years ago

Trying out how rewrite of StdLib with new generics and type classes would look like (see https://github.com/wurstscript/WurstScript/pull/931).

Feedback and tests with users of the library are very welcome.

Frotty commented 4 years ago

As mentioned I'm not too big of a fan of public implements as it sounds wrong. implementation or trait are probably more suited. Regarding ConvertIndex since it's more a property/trait shouldn't it be Indexable?

rhazarian commented 4 years ago

Probably it's performance-wise better to introduce a typeclass with methods to write and read the type to/from the native hashtable, so it would be possible to use HashMap with native types and strings without any overhead, as they would use their own methods, like saveString, loadString, etc.

peq commented 4 years ago

Yes, that's a good idea. Just have to figure out how to do this so that it's not necessary to implement two type classes for every type that does not have a hasmap native.