wurstscript / wurst-jar-wrapper

Windows executable wrapper for the wurstscript.jar
MIT License
3 stars 1 forks source link

"Forwarded run arguments" println is more noise than signal #9

Closed Cokemonkey11 closed 5 years ago

Cokemonkey11 commented 5 years ago

Forwarded run arguments: ["help"] <- remove this

Cokemonkey11 commented 5 years ago

@Frotty please can you review 7d6988d

Frotty commented 5 years ago

We don't need reviews for 1 line changes. You can just commit this to master. It's not gonna be used for some time anyway

Cokemonkey11 commented 5 years ago

I'm going to take that as you having reviewed it.

Code review isn't only for checking if the code works. It's for checking if we've successfully understood the specification.

Frotty commented 5 years ago

There was no PR, so yea

Cokemonkey11 commented 5 years ago

@Frotty yes there was - https://github.com/wurstscript/wurst-jar-wrapper/pull/11