search

wustho / baca

TUI Ebook Reader
GNU General Public License v3.0
363 stars 4 forks source link

Add a dependency to a specific version of climage or update code to be compatible with climage-0.2.0 #13

Closed Schplaf closed 11 months ago

Schplaf commented 1 year ago

Hello,

With CLImage-0.2.0, there were changes (variables renaming, etc.) that mean baca is not longer compatible with it. Therefore, baca-0.1.16 has a dependency with climage-0.1.3. In order to be able to use climage-0.2.0 with baca, please find attached this simple patch: patch-baca_with_CLImage-0.2.0.txt

wustho commented 11 months ago

Oh didn't realize this issue. Thanks for pointing that out, will fix it soon.

Schplaf commented 11 months ago

Great, thank you! (btw, baca is very useful and I use it almost daily)

xiota commented 11 months ago

I just now noticed this. Haven't used baca (or any other ereader) for a while. So didn't test after the climage 0.2.0 update.

Will add patch in aur/baca-ereader-git to fix for Arch Linux.

@Schplaf What distro are you using? How are you installing this? As far as I can tell, this program already specifies climage 0.1.3:

https://github.com/wustho/baca/blob/d32fb2f6fdd03b35d3d66c43057183473a50c778/pyproject.toml#L23

I believe ^0.1.3 specifies versions >= 0.1.3, but <0.2.0. However, depending on install method, version requirements may be ignored.

Schplaf commented 10 months ago

Sorry, I miss your answer: I use Gentoo and I maintain the package in a custom overlay.

Schplaf commented 10 months ago

Is it possible to add a new tag? (e.g. 0.1.17)

xiota commented 10 months ago

Is it possible to add a new tag? (e.g. 0.1.17)

This issue should already be fixed. See #16

Schplaf commented 10 months ago

Yes, it is. It was just a suggestion to add a tag in order to make the package maintenance easier.