wustho / baca

TUI Ebook Reader
GNU General Public License v3.0
363 stars 4 forks source link

switch from fuzzywuzzy to thefuzz? #8

Closed xiota closed 11 months ago

xiota commented 1 year ago

Upstream renamed fuzzywuzzy to thefuzz.

No urgency in switching because the Linux repositories I checked still provide python-fuzzywuzzy. But since it's apparently only a name change, maybe something like the following would work:

try:
    import thefuzz as fuzzywuzzy
except:
    import fuzzywuzzy
AnonymouX47 commented 1 year ago

What's the point of this when the dependency is specified? 🤔

https://github.com/wustho/baca/blob/8312be39d89fc8fe4369ab4ea757ada60b370613/pyproject.toml#L22

Since baca requires python>=3.10, why even use fuzzywuzzy at all? I think both the dependency and the import should just be changed entirely... or am I missing something?

wustho commented 1 year ago

Thanks for bringing that up @AnonymouX47 , at that time I only checked pypi page for fuzzywuzzy, so I didn't know that it was renamed to thefuzz, hence that issue. WIll fix this later.

wustho commented 1 year ago

And the PR is a prep for dependency change, no rush.

xiota commented 1 year ago

Depending on how programs are packaged, dependency lists can be treated as suggestions. Once installed, the program will use what's available. So distros that provide thefuzz can begin testing, even though the package still specifies fuzzywuzzy.

Treating dependency lists loosely is sometimes necessary. Not all distros provide thefuzz yet. Distros will start dropping fuzzywuzzy at different rates. Distros don't provide the same module versions. Different programs "require" different module versions. Some programs have inaccurate dependency lists. Etc.

AnonymouX47 commented 1 year ago

Oh, Ok.

wustho commented 11 months ago

Closing this one as it's already done