search

wustho / epr

CLI Epub Reader
MIT License
1.2k stars 49 forks source link

Mention Chocolatey in README.md #10

Closed spacecowgirl314 closed 5 years ago

spacecowgirl314 commented 5 years ago

I've created a chocolatey package for epr. The page for the is https://chocolatey.org/packages/epr. My source for the package is at https://github.com/cybercatgurrl/chocolatey-pkgs/tree/master/epr. You can mention something like you can install with Chocolatey "choco install epr" as soon as the package goes public.

Cheers!

wustho commented 5 years ago

Hello there, thankss for making it available in choco, but when I read it in choco package website, looks like it still uses old version of epr. I just made newer binary release: https://github.com/wustho/epr/releases/tag/v2.2.7

Could you update epr in choco by using v2.2.7b (not v2.2.7) which behave like common epub reader which common people accustomed to??

spacecowgirl314 commented 5 years ago

I can update it but only as soon as it is approved. Just a note for the future, adding a new version in an existing tag makes it harder to process in my automatic updating scripts. I'm working on setting up an appveyor build so that it automatically updates so it would be useful not to do this in the future.

wustho commented 5 years ago

Thanks mate, sorry so much I know nothing about batch scripting or something...

spacecowgirl314 commented 5 years ago

Now that the package was approved 2.2.7 has been submitted and awaiting review. As long as you don't add new versions to already existing tags my automatic scripts will keep should pick up your new releases and push them with appveyor. Cheers!

wustho commented 5 years ago

Thankss @cybercatgurrl

Just tried it, works perfectly...

But I kinda lost in:

As long as you don't add new versions to already existing tags

Can you please elaborate? What shall I do when releasing new versions so your scrit can automatically pick it up?

spacecowgirl314 commented 5 years ago

2.2.7b is a new version and not an alternate version like md right? Will there be a 2.3.0b or 2.2.8b? If it's a separate build then I can account for that but if it was a one off thing I can't account for that. Like if 2.2.7b is a new version of the program then it would have been picked up if you made a new release.

The script will only pick it up if there is a new release. So for instance if 2.2.8 is released then it will automatically package epr-v2.2.8-win.zip and push it to chocolatey. Or should it be packaging epr-v2.2.8b-win.zip?

wustho commented 5 years ago

Or should it be packaging epr-v2.2.8b-win.zip?

Is it too much bother for you if it should?

2.2.7b is a new version and not an alternate version like md right?

It is actually alternate version, v2.2.7 and v2.2.7b has the same features, just different behaviour when navigating via TOC, what do you think?

spacecowgirl314 commented 5 years ago

Sure I can change the script to reflect that. As long as that continues to be the naming convention for releases. On 9 May 2019, 7:03 PM +1000, Benawi Adha notifications@github.com, wrote:

Or should it be packaging epr-v2.2.8b-win.zip? Is it too much bother for you if it should? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

wustho commented 5 years ago

Yess thanks so much, I will consistently update it with vX.X.Xb...

Just update the README