VCLibrarianTool LinkTimeCodeGeneration causing warning.

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Create a gyp file with the following structure embedded

'configurations': {
  'Release': {
    'msvs_settings': {
      'VCLibrarianTool': {
        'LinkTimeCodeGeneration': 'true',

2. Attempt to run gyp on this gyp file.

What is the expected output? What do you see instead?
Expected static library projects to have /LTCG added to Librarian command line. 
In fact, this did seem to happen, but I also received a number of lines like

Warning: unrecognized setting VCLibrarianTool/LinkTimeCodeGeneration

What version of the product are you using? On what operating system?
Gyp r1057 on Windows7, both VS2008 and 2010. Generating gyps for skia.

Please provide any additional information below.
I am attaching a patch. This change changes LinkTimeCodeGeneration from 
_MSBuildOnly to _Same as it can be found at both

http://msdn.microsoft.com/en-us/library/ee862484.aspx
and
http://msdn.microsoft.com/en-us/library/microsoft.visualstudio.vcprojectengine.v
clibrariantool.aspx

Original issue reported on code.google.com by bunge...@google.com on 30 Sep 2011 at 6:04

Attachments:

• LinkTimeCodeGeneration.diff

[GoogleCodeExporter]

Issue 227 has been merged into this issue.

Original comment by mark@chromium.org on 30 Sep 2011 at 8:56

[GoogleCodeExporter]

Review at http://codereview.appspot.com/5166044/

Original comment by bunge...@google.com on 30 Sep 2011 at 9:15

[GoogleCodeExporter]

Original comment by bunge...@chromium.org on 3 Oct 2011 at 5:51

• Changed state: Fixed