wutong16 / Voxurf

[ ICLR 2023 Spotlight ] Pytorch implementation for "Voxurf: Voxel-based Efficient and Accurate Neural Surface Reconstruction"
Other
403 stars 27 forks source link

[Reproduce] Ablation study on hierarchical sampling : Tab3, Figure7 #37

Open minsu1206 opened 9 months ago

minsu1206 commented 9 months ago

Hi Thank you for sharing nice work.

I'm interested in proposed hierarchical sampling's effects I tried to reproduce ablation study on it, but got stuck in making appropriate config files.

I changed some lines at dtu_e2e/fine.py grad_feat=(0.5, 1.0, 1.5, 2.0,) -> grad_feat = () sdf_feat =(0.5, 1.0, 1.5, 2.0,) -> sdf_feat = 0

But I met assertion error at voxurf_fine.py line 683 ; assert all_grad_inds == all_sdf_inds

To solve this issue, I also tried to change k_grad_feat =(1.0) -> k_grad_feat=( ) but this made another assertion error at voxurf_fine.py line 731 ; assert len(self.k_grad_feat) == 1 and self.k_grad_feat[0] == 1.0

Here, My question is How can I get same results at Tab3 or Figure7 in the paper? Please give me the instruction.

Thank you in advance!

minsu1206 commented 9 months ago

I could run the experiment with (1) change dtu_e2e/fine.py grad_feat = ( ) sdf_feat = ( ) k_grad_feat = (0.0,)

(2) comment code lines at volume_fine.py - forward

k0 = self.k0(ray_pts)
# all_grad_inds = list(set(self.grad_feat + self.k_grad_feat))
# all_sdf_inds = list(set(self.sdf_feat + self.k_sdf_feat))
# assert all_grad_inds == all_sdf_inds
all_grad_inds = [ ]
if self.use_rgb_k:
# assert len(self.k_grad_feat) == 1 and self.k_grad_feat[0] == 1.0
# assert len(self.k_sdf_feat) == 0
all_feats_ = [gradient]

But I still have no convince if my setting is right or not